Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add variable through file formatter #1978

Merged
merged 7 commits into from
Feb 28, 2023
Merged

add variable through file formatter #1978

merged 7 commits into from
Feb 28, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Feb 15, 2023 •
edited
Loading

The PR enables file formatter to add a variable to existing file

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Feb 15, 2023
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner February 15, 2023 18:12
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

3 similar comments
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@weiyuan-jiang
Copy link
Contributor Author

@tclune Why the test fails even I just add an empty test ?

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

2 similar comments
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@weiyuan-jiang weiyuan-jiang added 🎁 New Feature This is a new feature and removed 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Feb 15, 2023
@weiyuan-jiang
Copy link
Contributor Author

It suddenly passes all tests

@tclune
Copy link
Collaborator

tclune commented Feb 16, 2023

Sorry - I fell behind on monitoring MAPL issues. The @tclune should have gotten it into my priority inbox, but ... apparently not. Must be a bug in my filters. Let me know if there is something that needs my attention.

@weiyuan-jiang
Copy link
Contributor Author

@tclune Before this PR, MAPL cannot add variables to an existing netcdf file ( it can create a new one). This PR adds that function. It helps gigatraj when users are trying to add some extra variables to an existing particles's position file.

@weiyuan-jiang weiyuan-jiang added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Feb 16, 2023
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@weiyuan-jiang weiyuan-jiang removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Feb 16, 2023
@mathomp4
Copy link
Member

@weiyuan-jiang Do you think this is ready to go?

mathomp4
mathomp4 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model didn't seem to crash. Approve.

@mathomp4 mathomp4 merged commit 8bef386 into develop Feb 28, 2023
@mathomp4 mathomp4 deleted the feature/wjiang/add_var_formatter branch February 28, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiyuan-jiang @tclune @mathomp4