Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let users specify the grid type #1989

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Let users specify the grid type #1989

merged 3 commits into from
Feb 28, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Feb 27, 2023 •
edited
Loading

This PR tries to address this issue GEOS-ESM/GOCART#207 . With this fix, users can specify the external grid type through config.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 27, 2023
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner February 27, 2023 22:15
@weiyuan-jiang
Copy link
Contributor Author

@aoloso What do you think of this change? Should we give users a chance to specify the grid type?

@mathomp4
Copy link
Member

@aoloso What do you think of this change? Should we give users a chance to specify the grid type?

Might also want to ping @bena-nasa for his opinion.

@mathomp4 mathomp4 merged commit 52137b8 into develop Feb 28, 2023
@mathomp4 mathomp4 deleted the feature/wjiang/set_grid_users branch February 28, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weiyuan-jiang @mathomp4