Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2268 - rename geom subdir #2269

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Fixes #2268 - rename geom subdir #2269

merged 5 commits into from
Jul 31, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Jul 31, 2023

Just some simple renames.

Description

Related Issue

Motivation and Context

Existing name was in the way of other items that fit the name better.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a build of GEOSgcm (if non-trivial)
  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune tclune added 0 diff structural 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related labels Jul 31, 2023
@tclune tclune requested review from a team as code owners July 31, 2023 13:05
atrayano
atrayano previously approved these changes Jul 31, 2023
View reviewed changes
mathomp4
mathomp4 previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, it should be good!

@mathomp4 mathomp4 linked an issue Jul 31, 2023 that may be closed by this pull request
Rename geom subdirectory #2268
Closed
@mathomp4 mathomp4 self-requested a review July 31, 2023 15:36
mathomp4
mathomp4 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-Approve!

@tclune tclune merged commit 1644ef0 into develop Jul 31, 2023
25 checks passed
@tclune tclune deleted the feature/tclune/#2268-rename-geom branch July 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename geom subdirectory
3 participants
@tclune @mathomp4 @atrayano