Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up more geom to field_utils #2272

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

mathomp4
Copy link
Member

Description

In consultation with @tclune we found a few more remnants of geom as well as some stray "mapl3g" in develop. This cleans it up.

Related Issue

Motivation and Context

Keeps the code clean and consistent.

How Has This Been Tested?

Well, depending on the CI as this should be a simple refactor.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jul 31, 2023
@mathomp4 mathomp4 self-assigned this Jul 31, 2023
@mathomp4 mathomp4 requested review from a team as code owners July 31, 2023 16:25
@mathomp4 mathomp4 merged commit d89ec15 into develop Jul 31, 2023
29 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/more-geom-renames branch July 31, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants