Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadForcing binary file converter #2276

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Jul 31, 2023

Now that ExtData2g can read tiles, there is just no reason not started a concerted effort to retire MAPL_ReadForcing.
Of course users will object that how can we convert all these existing data files? Well, now they can. I've made python scripts that I believe should be adequate to convert all existing use cases of the binary files read by MAPL_ReadForcing into files that can be used by ExtData.

I decided for now just to make a YAML input where one can enumerate the files that need to be converted and the information needed to convert since they are not self describing so it is up to the user to tell it what to put in the NetCDF file that will be made and what was in the input file to a degree. For example, for lat-lon forcing files, there's no conceivable why I could possibly auto detect what the grid is. I just know I have record of a certain size and that's that, so the grid could be of a size that any two integers that multiple together to get that record size is "legal".

Now, I may have done a bad way of including these scripts in the CMakeLists.txt file or maybe they should be elsewhere. I just made a directory in Apps.
Please advise if I should update where these are and how they are installed.

I also followed what I was was done for remap_restarts.py in in GEOS_Utils and included the documentation in code, that was new to me, just stumbled across that you could embed that in the help. I.E. running --help will bring up a large help statement that demonstrates use.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Jul 31, 2023
@bena-nasa bena-nasa requested review from a team as code owners July 31, 2023 21:11
@bena-nasa bena-nasa merged commit 6df071b into develop Aug 1, 2023
27 checks passed
@bena-nasa bena-nasa deleted the feature/bmauer/read_forcing_converter branch August 1, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants