ReadForcing binary file converter #2276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that ExtData2g can read tiles, there is just no reason not started a concerted effort to retire MAPL_ReadForcing.
Of course users will object that how can we convert all these existing data files? Well, now they can. I've made python scripts that I believe should be adequate to convert all existing use cases of the binary files read by MAPL_ReadForcing into files that can be used by ExtData.
I decided for now just to make a YAML input where one can enumerate the files that need to be converted and the information needed to convert since they are not self describing so it is up to the user to tell it what to put in the NetCDF file that will be made and what was in the input file to a degree. For example, for lat-lon forcing files, there's no conceivable why I could possibly auto detect what the grid is. I just know I have record of a certain size and that's that, so the grid could be of a size that any two integers that multiple together to get that record size is "legal".
Now, I may have done a bad way of including these scripts in the CMakeLists.txt file or maybe they should be elsewhere. I just made a directory in Apps.
Please advise if I should update where these are and how they are installed.
I also followed what I was was done for remap_restarts.py in in GEOS_Utils and included the documentation in code, that was new to me, just stumbled across that you could embed that in the help. I.E. running --help will bring up a large help statement that demonstrates use.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: