Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/atrayano/#2304 index user #2305

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Feature/atrayano/#2304 index user #2305

merged 3 commits into from
Aug 9, 2023

Conversation

atrayano
Copy link
Contributor

@atrayano atrayano commented Aug 9, 2023

Description

This PR replaced the usage of index flad ESMF_INDEX_USER with ESMF_INDEX_DELOCAL

Related Issue

#2304

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • [ x] I have tested this change with a run of GEOSgcm (if non-trivial)
  • [ x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • [x ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@atrayano atrayano added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 9, 2023
@atrayano atrayano requested review from a team as code owners August 9, 2023 15:41
@tclune
Copy link
Collaborator

tclune commented Aug 9, 2023

Wrong base: edit main --> develop

@atrayano atrayano changed the base branch from main to develop August 9, 2023 15:55
tclune
tclune reviewed Aug 9, 2023
View reviewed changes
base/MAPL_LocStreamMod.F90 Outdated Show resolved Hide resolved
tclune
tclune reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about the error handling. Once you click to accept the suggestion, I can approve.

@atrayano @tclune
Update base/MAPL_LocStreamMod.F90
55a7ee9 
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@atrayano atrayano merged commit 836f2a5 into develop Aug 9, 2023
25 checks passed
@atrayano atrayano deleted the feature/atrayano/#2304_index_user branch August 9, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atrayano @tclune