Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPT + GNU bug at NAS #2345

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Sep 8, 2023

Description

This fixes #2344 by renaming a variable from mpi_comm to comm. My theory is MPT weird because I have to build modules for GNU at NAS. This is not a bug in MAPL, more in MPT, but it's easier to just work around it in MAPL.

Related Issue

Closes #2344

Motivation and Context

Let's the model build at NAS with GNU.

How Has This Been Tested?

If this builds, it should be good.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 8, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner September 8, 2023 13:36
@mathomp4 mathomp4 self-assigned this Sep 8, 2023
@mathomp4 mathomp4 linked an issue Sep 8, 2023 that may be closed by this pull request
@mathomp4 mathomp4 merged commit 2d59331 into develop Sep 8, 2023
29 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/mpt-gnu-bugfix branch September 8, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAPL develop and MAPL3 Build Failure at NAS with GNU
2 participants