Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get back to main to get the right idle_worker #2348

Merged
merged 2 commits into from
Sep 14, 2023
Merged

get back to main to get the right idle_worker #2348

merged 2 commits into from
Sep 14, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Sep 14, 2023 •
edited

The idle_worker was wrong because of the change of order of the lines by accident. get back to the right order

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 🪲 Bug Something isn't working 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Sep 14, 2023
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 14, 2023 15:26
@mathomp4 mathomp4 merged commit 5275e62 into develop Sep 14, 2023
33 checks passed
@mathomp4 mathomp4 deleted the hotfix/wjiang/idle_worker branch September 14, 2023 16:53
@mathomp4
Copy link
Member

Awww nuts. I just merged this and I didn't see it was a hotfix. Well, maybe this will prompt us to make a release of MAPL from develop. cc @tclune

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiyuan-jiang @mathomp4 @tclune