Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for NVHPC #2395

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Fixes for NVHPC #2395

merged 14 commits into from
Feb 8, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Oct 3, 2023

Description

This PR collects changes found in work with NVHPC. This is a work in progress, but with these changes, NVHPC 27.5 does compile most of MAPL. Current issues are with executables.

Related Issue

Motivation and Context

Let's MAPL build with NVHPC.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 3, 2023
@mathomp4 mathomp4 self-assigned this Oct 3, 2023
Copy link

stale bot commented Jan 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Jan 20, 2024
@mathomp4 mathomp4 added the ⌛ Long Term Long term issues label Jan 22, 2024
@stale stale bot removed the ❄️ Stale This issue has been marked stale label Jan 22, 2024
generic/OpenMP_Support.F90 Outdated Show resolved Hide resolved
tclune
tclune previously approved these changes Feb 8, 2024
@mathomp4 mathomp4 marked this pull request as ready for review February 8, 2024 17:38
@mathomp4 mathomp4 requested a review from a team as a code owner February 8, 2024 17:38
@mathomp4 mathomp4 changed the title WIP: Fixes for NVHPC Fixes for NVHPC Feb 8, 2024
@mathomp4 mathomp4 merged commit 672f440 into develop Feb 8, 2024
31 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/nvhpc-fixes branch February 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. ⌛ Long Term Long term issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants