Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Code Generator Sample Code (0 diff) #2420

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

JulesKouatchou
Copy link
Contributor

Description

  • We provide a sample code that shows how to use the Automatic Code Generator tool.
  • The code reflects the example presented in the documentation.
  • The code comes with a spec file and a CMakeLists.txt file needed for the tool to work properly.

Related Issue

Motivation and Context

The sample code is meant to provide an example on the necessary changes users need to introduce in their application if they want to use the automatic code generator tool.

How Has This Been Tested?

Our main task was to only make sure that the code could compile by generating the necessary __.h files (four of them). The code is not used to create any executable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@JulesKouatchou JulesKouatchou requested review from a team as code owners October 26, 2023 22:52
@tclune tclune changed the base branch from main to develop October 27, 2023 11:30
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested.

@mathomp4
Copy link
Member

@JulesKouatchou Can you also include a CHANGELOG entry about this as well (along with @tclune 's suggestion?)

@tclune
Copy link
Collaborator

tclune commented Oct 27, 2023

Not strongly opposed, but ... the directory is not the acg. It is stuff that uses the acg. Maybe obvious(ish) from context, but I'd prefer something that indicated that it does not in fact contain the ACG.

@tclune
Copy link
Collaborator

tclune commented Oct 27, 2023

Our usual convention is that gridcomps have the same name as the directory that they are in.

Long story, but the convention got botched during early deployment so we have dirs like: GEOSgcm_GridComp that are supposed to be GEOS_GcmGridComp. Going to Git was supposed to let us do that, but we've been afraid to pull the trigger.

@JulesKouatchou
Copy link
Contributor Author

  • Changed the directory name (automatic_code_generator) and file names (ACG_GridComp.F90 and ACG_StateSpecs.rc).
  • Edited the CHANGELOG.md file
  • Verified that the new sample code still compiles.

@tclune tclune self-requested a review October 27, 2023 17:10
tclune
tclune previously approved these changes Oct 27, 2023
tclune
tclune previously approved these changes Oct 30, 2023
@mathomp4
Copy link
Member

I pushed a conflict fix up. I couldn't do it on the web.

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 30, 2023
@mathomp4 mathomp4 merged commit 57429a5 into develop Oct 30, 2023
28 of 29 checks passed
@mathomp4 mathomp4 deleted the feature/jk/doc/code_generator branch October 30, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants