Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2433 Minor changes for gfortran-13. #2443

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Nov 11, 2023

Simple workarounds for regressions in the compiler.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Simple workarounds for regressions in the compiler.
@tclune tclune added the bugfix label Nov 11, 2023
@tclune tclune requested a review from a team as a code owner November 11, 2023 02:10
@mathomp4 mathomp4 self-requested a review November 11, 2023 21:20
@mathomp4
Copy link
Member

Huh. One of the ifort tests failed: MAPL.field_utils.tests

 Start: <Test_FieldBLAS_suite.test_FieldSCAL_R4>
forrtl: error (72): floating overflow
Image              PC                Routine            Line        Source             
MAPL.field_utils.  000000000075A66B  Unknown               Unknown  Unknown
libpthread-2.31.s  00007FEE11FE2420  Unknown               Unknown  Unknown
libMAPL.field_uti  00007FEE177FFDD0  mapl_fieldblas_mp          86  FieldBLAS.F90
MAPL.field_utils.  000000000043F563  test_fieldblas_mp         132  Test_FieldBLAS.pf
MAPL.field_utils.  00000000004A3C41  pf_testmethod_mp_          89  TestMethod.F90
libMAPL.pfunit.so  00007FEE16DAAE9D  pf_testcase_mp_ru         136  TestCase.F90
libMAPL.pfunit.so  00007FEE16DAB1C9  pf_testcase_mp_ru         146  TestCase.F90
MAPL.field_utils.  00000000004AA240  pf_testresult_mp_         237  TestResult.F90
libMAPL.pfunit.so  00007FEE16DAAA4B  pf_testcaserun_mp         121  TestCase.F90

@tclune tclune added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 13, 2023
@tclune
Copy link
Collaborator Author

tclune commented Nov 13, 2023

@mathomp4 The failing ifort test is weird:

The following tests FAILED:
         10 - MAPL.field_utils.tests (Failed)
Errors while running CTest

First, that code was not modified in this PR and second, it passes on my laptop. Granted laptop is 2021.10, but ...

If you have a chance, maybe retrigger that test suite?

@mathomp4
Copy link
Member

Okay. I've retriggered. Let's see what happens!

@mathomp4
Copy link
Member

@tclune You were right. Must have been a CircleCI bloop. All passing now.

@tclune
Copy link
Collaborator Author

tclune commented Nov 13, 2023

@mathomp4 - please merge when you can. (ADAS still failing so I cannot.) I'd like to get these into MAPL3 so that I don't fix these twice.

@mathomp4 mathomp4 merged commit 9bbe69f into develop Nov 13, 2023
30 of 33 checks passed
@mathomp4 mathomp4 deleted the feature/tclune/port-to-gfortran-13 branch December 18, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants