Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print helpful information for certain ExtData problems. #2452

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Nov 20, 2023

Description

Added info in _ASSERT messages to aid in debugging ExtData.yaml files.

Related Issue

Motivation and Context

These edits help users resolve problems in ExtData yaml specifications, with
more informative messages. This is by no means an exhaustive review of the code,
it is just a set of ASSERT statements that was accumulated in the process of
debugging a large hand-crafted yaml specification, during which MAPL would
terminate the model without providing a clue as to which section of yaml was problematic.

How Has This Been Tested?

This was tested using a standard PCHEM configuration of the GCM.
It is zero-diff except when MAPL encounters certain fatal errors, in which case it
prints a little more information in the slurm log.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Additional diagnostic information

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mmanyin mmanyin added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Nov 20, 2023
@mmanyin mmanyin requested a review from a team as a code owner November 20, 2023 21:33
bena-nasa
bena-nasa previously approved these changes Dec 5, 2023
@mathomp4 mathomp4 merged commit 7086edb into develop Dec 20, 2023
6 of 16 checks passed
@mathomp4 mathomp4 deleted the feature/mmanyin/ExtData_explain_error branch December 20, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants