Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field allocation for SSI capability #2471

Merged
merged 19 commits into from
Dec 21, 2023
Merged

Conversation

aoloso
Copy link
Contributor

@aoloso aoloso commented Dec 5, 2023

Allocate gridded fields to use the pinflag option needed for the Single System Image (SSI) capability.

Description

In subroutine MAPL_FieldAllocCommit, gridded fields are allocated from scratch with the pinflag option such that the SSI capability of ESMF can be used as necessary. Using thsi capability is essential for the mixed hybrid code with the dyncore hybrid MPI/OpenMP and the rest of GEOS GCM using only MPI.

Related Issue

Motivation and Context

Mixed hybrid code

How Has This Been Tested?

Zero diff through c720

Stock g5_module but with ESMA-Baselibs-7.16.0 (at least ESMF 8.6.0)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

aoloso and others added 16 commits September 13, 2023 17:56
…his allows explicit specification of indexflag required by the new MAPL field split functionality. This functionality allows a clean way to create a new field from an exiting field where the new field is a 'slice' of the existing field with the slicing index being that of the trailing ungiridded dim of the existing field
…ith just _RC in line with our new convention
…o assess the SIngle System Image capability of ESMF that is needed or the 'mixed' hybrid approach for GEOS GCM where only the dyncore is hybrid MPI/OpenMP and everything else stays only MPI, both sides using the same number of total PEs
@aoloso aoloso requested a review from a team as a code owner December 5, 2023 02:31
@aoloso aoloso requested a review from a team as a code owner December 5, 2023 02:31
@mathomp4 mathomp4 changed the base branch from main to develop December 5, 2023 15:34
@mathomp4
Copy link
Member

mathomp4 commented Dec 5, 2023

I think this is meant to go to develop. I'll update the base.

gridcomps/Cap/MAPL_Cap.F90 Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mathomp4 mathomp4 added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Dec 20, 2023
@mathomp4 mathomp4 removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Dec 21, 2023
@mathomp4
Copy link
Member

NOTE: I think the CI issues are due to CI quirks grabbing the other feature/aoloso/hybrid_112923 branches in FV and GCM (via mepo checkout-if-exists). I can confirm both Intel Release and Debug run. I'm doing GNU Release and Debug tests now.

@mathomp4 mathomp4 requested a review from tclune December 21, 2023 18:12
@mathomp4 mathomp4 merged commit d5b695e into develop Dec 21, 2023
20 of 27 checks passed
@mathomp4 mathomp4 deleted the feature/aoloso/hybrid_112923 branch December 21, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants