Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2499: Allow ExtData2G to be built static #2500

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

mathomp4
Copy link
Member

Description

Fixes the CMake in ExtData2G to allow it to be built as STATIC

Related Issue

Closes #2499

Motivation and Context

Our UFS friends build MAPL as STATIC and this fixes a bug with that.

How Has This Been Tested?

Built the model with -DBUILD_SHARED_MAPL=NO and ran GEOSgcm.x. Zero-diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 20, 2023
@mathomp4 mathomp4 self-assigned this Dec 20, 2023
@mathomp4 mathomp4 requested review from a team as code owners December 20, 2023 16:26
@mathomp4 mathomp4 merged commit 2eb9da2 into develop Dec 20, 2023
27 of 29 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/2499-fix-shared-extdata2g branch December 20, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants