Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fields utils, Issue #2530 #2538

Merged
merged 8 commits into from
Jan 19, 2024
Merged

Conversation

darianboggs
Copy link
Contributor

Description

This feature PR adds the npes to the @Test decorators. It also moves creation of some fields to the test subroutines so that the field creation is consistent with the regDecomp argument.

Related Issue

#2530

Motivation and Context

npes were not being passed into the test subroutines.

How Has This Been Tested?

Ran the MAPL tests in question

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@darianboggs darianboggs added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring labels Jan 17, 2024
@darianboggs darianboggs self-assigned this Jan 17, 2024
@darianboggs darianboggs requested a review from a team as a code owner January 17, 2024 21:01
@tclune tclune self-requested a review January 19, 2024 19:13
@tclune tclune merged commit 7baf233 into develop Jan 19, 2024
29 checks passed
@tclune tclune deleted the feature/wdboggs/#2530-fix-field-utils branch January 19, 2024 19:13
@mathomp4 mathomp4 mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants