Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2553. Detect mpiuni builds of ESMF #2556

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 26, 2024

Description

This PR adds a check in Cap after ESMF_Initialize to see if ESMF was built as mpiuni which is not supported by MAPL (we require "real" MPI). Thanks to @oehmke, ESMF_VmGet can tell us the comm.

Related Issue

Closes #2553

Motivation and Context

It was found that a GCHP issue could have been quickly diagnosed if this assertion was in MAPL.

How Has This Been Tested?

Currently testing to make sure GEOSgcm runs. It should, but good to be safe.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 26, 2024
@mathomp4 mathomp4 self-assigned this Jan 26, 2024
@mathomp4 mathomp4 linked an issue Jan 26, 2024 that may be closed by this pull request
@mathomp4 mathomp4 marked this pull request as ready for review January 26, 2024 18:17
@mathomp4 mathomp4 requested a review from a team as a code owner January 26, 2024 18:17
@mathomp4 mathomp4 merged commit d8fdef7 into develop Jan 30, 2024
29 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/2553-detect-mpiuni branch January 30, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect serial build of ESMF?
2 participants