Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nf90 interface to read and write 1d string #2568

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Feb 2, 2024

Description

added nf90 interface to read and write 1d string

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 2, 2024
@weiyuan-jiang weiyuan-jiang requested review from a team as code owners February 2, 2024 20:17
bena-nasa
bena-nasa previously approved these changes Feb 2, 2024
tclune
tclune previously approved these changes Feb 2, 2024
@weiyuan-jiang weiyuan-jiang dismissed stale reviews from tclune and bena-nasa via 11b8c07 February 5, 2024 20:12
@metdyn
Copy link
Contributor

metdyn commented Feb 6, 2024

Thank you, very much, @weiyuan-jiang for your work!
We got the station names printed out nicely!

        string station_name(station_index) ;
                station_name:long_name = "station name" ;

station_name = "Ames_AERO", "Appalachian_State_AERO", "ARM_Oliktok_AK_AERO",
    "ARM_SGP_AERO", "Bakersfield_AERO", "Barrow_AERO", "Billerica_AERO",
    "Bonanza_Creek_AERO", "BONDVILLE_AERO", "Bozeman_AERO",
    "Brookhaven_AERO", "CalTech_AERO", "Cape_San_Juan_AERO", "CARTEL_AERO",
    "Chapais_AERO", "Churchill_AERO", "Cold_Lake_AERO", "Dayton_AERO",
    "Denver_LaCasa_AERO", "DigitalGlobe_Cal_AERO", "EastMalling_MO_AERO",
    "Easton-MDE_AERO", "Egbert_AERO", "EPA-Res_Triangle_Pk_AERO",
    "Fort_McMurray_AERO", "Fresno_2_AERO", "Georgia_Tech_AERO",
    "Goldstone_AERO", "Grand_Forks_AERO", "Granite_Island_AERO", "TROPOZ",
    "Halifax_AERO", "Hart_Miller_Island_AERO", "IMPROVE-MammothCave_AERO",
    "Kangerlussuaq_AERO", "Kellogg_LTER_AERO", "Kelowna_UAS_AERO",
    "Key_Biscayne_AERO", "Kluane_Lake_AERO", "La_Parguera_AERO",

@mathomp4 mathomp4 requested review from tclune and a team February 6, 2024 20:39
@mathomp4 mathomp4 merged commit 0a5a8ce into develop Feb 6, 2024
29 checks passed
@mathomp4 mathomp4 deleted the feature/wjiang/nf90_string_interface branch February 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants