Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field utils tests #2584

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

darianboggs
Copy link
Contributor

Description

There were problems in the tests in field_utils for Test_FieldArithmetic.pf and Test_FieldBLAS.pf:

  1. Mismatch between Fortran array and ESMF_Field values
  2. Incorrect parallel tests

Tom fixed this in release/MAPL-v3. This PR brings in those changes, and only those changes, from release/MAPL-v3. Also, it removes variables in field_utils_setup.F90 that were no longer needed for the tests. The variables were module-level, and they were present in procedure argument lists and calls to those procedures. Nonetheless, the important changes are those that address items 1 and 2 above.

Related Issue

Motivation and Context

Tests were crashing, and the tests weren't actually performing the desired validation.

How Has This Been Tested?

This PR was tested by the MAPL tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@darianboggs darianboggs added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Feb 7, 2024
@darianboggs darianboggs self-assigned this Feb 7, 2024
@darianboggs darianboggs requested a review from a team as a code owner February 7, 2024 21:14
@darianboggs
Copy link
Contributor Author

This PR fixes issue #2549, and it replaces (closes) PR ##2551.

@mathomp4
Copy link
Member

mathomp4 commented Feb 7, 2024

Woo! All pass! 👍🏼

@tclune tclune merged commit 5c8180c into develop Feb 8, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants