Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error in filename when wild character is introduced into template #2769

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented Apr 19, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

A bug in filename output is found then fixed when reading in
template=aist-nr/data/ioda_reshuffle/%y4%m2%d2/geos_atmosphere/omi_aura.%y4%m2%d2T%h2%n2%S2Z.nc4

Related Issue

@metdyn metdyn requested a review from a team as a code owner April 19, 2024 19:51
@metdyn metdyn added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Apr 19, 2024
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - but I think it would be interesting to eliminate the nested conditionals that were added here. But ... other priorities.

@tclune tclune merged commit fb96c72 into develop Apr 22, 2024
38 of 39 checks passed
@tclune tclune deleted the feature/fix_an_error_in_filename branch April 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants