Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some prep work for extdata2g vertical regridding development #2949

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Aug 5, 2024

Trivial changes in preparation for ExtData vertical regridding work. Please approve.
I've done:

  1. changed all rc=status); _VERIFY(status) to the _RC macro in ExtData2G grid comp for readability
  2. Added a new driver, it's just like ExtDataDriver.x but rather than run my custom cap, this just exercises the regular cap, but has the "Root" component being the same configurable component ExtDataDriver.x uses. This will let me test changes I need to make to CapGridComp.F90

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring ❗ High Priority This is a high priority PR labels Aug 5, 2024
@bena-nasa bena-nasa requested review from a team as code owners August 5, 2024 17:08
@bena-nasa bena-nasa requested a review from tclune August 5, 2024 17:08
@bena-nasa
Copy link
Collaborator Author

bena-nasa commented Aug 5, 2024

Had to made a library in Tests so the executables would not cause race condition in build

@tclune tclune merged commit aa8511e into develop Aug 6, 2024
36 checks passed
@tclune tclune deleted the feature/bmauer/extdata_vertical_prep branch August 6, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. ❗ High Priority This is a high priority PR 🎁 New Feature This is a new feature 🛠️ Refactor This is code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants