Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ESMF_CONTEXT_PARENT_VM default for ESMF_GridComp creation in generic3g/GenericGridComp.F90 (MAPL3) #2952

Merged

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Make ESMF_CONTEXT_PARENT_VM the default ESMF_Context_Flag in create_grid_comp in mapl3g_GenericGridComp (generic3g/GenericGridComp.F90). This makes child components use the parent ESMF_VM by default.

Related Issue

#2948

@darianboggs darianboggs added the 📈 MAPL3 MAPL 3 Related label Aug 6, 2024
@darianboggs darianboggs self-assigned this Aug 6, 2024
@darianboggs darianboggs requested a review from a team as a code owner August 6, 2024 17:33
@darianboggs darianboggs added the 😲 Non 0 Diff The changes in this pull request are non-zero-diff. label Aug 6, 2024
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed at least one more in couplers/GenericCoupler.F90. (Does not have petlist, so even easier fix.)

Please do a grep for GridCompCreate (and ignore all MAPL2 instances).

@darianboggs
Copy link
Contributor Author

I ran this grep yesterday morning:

Apps/Comp_Testing_Driver.F90, "temp_GC = ESMF_GridCompCreate(name=comp_name, _RC)"
Tests/ExtDataDriverGridComp.F90, "cap%gc = ESMF_GridCompCreate(name='ExtData_DriverGridComp', rc = status)"
base/MAPL_CFIO.F90, "!ALT MCFIO%GC = ESMF_GridCompCreate("NULL")"
base/TeX/MAPL_Intro.tex, "GC = ESMF_GridCompCreate(name='ExampleGC', rc=rc)"
docs/user_guide/docs/mapl_core.md, "GC = ESMF_GridCompCreate(name='ExampleGC', rc=rc)"
generic/MAPL_Generic.F90, "child_meta%gridcomp = ESMF_GridCompCreate ( &"
generic/OpenMP_Support.F90, "gc = ESMF_GridCompCreate(name=trim(comp_name), config=CF, petlist=[myPet], &"

generic3g/GenericGridComp.F90, "gridcomp = ESMF_GridCompCreate(name=outer_name(name), petlist=petlist, _RC)"
generic3g/GenericGridComp.F90, "user_gridcomp = ESMF_GridCompCreate(name=name, petlist=petlist, _RC)"
generic3g/couplers/GenericCoupler.F90, "coupler_gridcomp = ESMF_GridCompCreate(name='coupler', _RC)"
generic3g/couplers/esmf-way/GenericCoupler.F90, "gridcomp = ESMF_GridCompCreate(...)"
gridcomps/Cap/MAPL_CapGridComp.F90, "cap%gc = ESMF_GridCompCreate(name=cap_name, config=cap%config, _RC)"
mapl3g/MaplFramework.F90, "gridcomp = ESMF_GridCompCreate(petList=petList, _RC)"
pfunit/ESMF_TestCase.F90, "gc = ESMF_GridCompCreate(petList=[(pet,pet=0,this%getNumPETsRequested()-1)], rc=rc)"

I'll make the change to generic3g/couplers/GenericCoupler.F90

@darianboggs
Copy link
Contributor Author

Change made

@tclune tclune self-requested a review August 6, 2024 19:05
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

@darianboggs darianboggs merged commit a14bc23 into release/MAPL-v3 Aug 6, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😲 Non 0 Diff The changes in this pull request are non-zero-diff. 📈 MAPL3 MAPL 3 Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants