Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future ability to test ifx in CI #2956

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Aug 9, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This is an update to CI to eventually allow the ability to add ifx. At the moment ifx does not run the MAPL tests (though it can build), it can build GEOSgcm but not run it, and it just cannot build GEOSldas (due to missing HDF4 Fortran headers, see GEOS-ESM/GEOSldas_GridComp#55).

Related Issue

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Aug 9, 2024
@mathomp4 mathomp4 self-assigned this Aug 9, 2024
@mathomp4
Copy link
Member Author

mathomp4 commented Aug 9, 2024

Oh yeah. ifx + MAPL means test failures at the moment. See:

https://app.circleci.com/pipelines/github/GEOS-ESM/MAPL/9508/workflows/69823f8f-67cf-4525-a489-5a4adfd828aa/jobs/78296

Perhaps if I can work with @tclune to fix the MAPL.base.tests failure, we'd solve the ExtData2G_case24 case fail as well?

@tclune
Copy link
Collaborator

tclune commented Aug 11, 2024

Hmm. That crash is basically in a bit of code that is extracting a C address of an array. The problem must be farther upstream. Also interesting that the stacktrace itself is missing the intermediary lines between GriddedIO and CubedSphereGridFactory.

Quite possibly a compiler bug, but has enough noise that it could also be some latent uninitialized thingo(TM) in our code.

@mathomp4 mathomp4 changed the title Test adding ifx to CI Add future ability to test ifx in CI Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants