Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compare brief by default, add --all option #218

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 24, 2022

This PR changes the default behavior of mepo compare. Now, mepo compare will only show differing repos:

❯ mepo compare
Repo                   | Original                         | Current
---------------------- | -------------------------------- | -------
env                    | (t) v3.11.0 (DH)                 | (b) main
cmake                  | (t) v3.10.0 (DH)                 | (b) develop
MAPL                   | (t) v2.17.2 (DH)                 | (b) develop

To see all repos, use --all:

❯ mepo compare --all
Repo                   | Original                         | Current
---------------------- | -------------------------------- | -------
GEOSgcm                | (b) main                         | (b) main
env                    | (t) v3.11.0 (DH)                 | (b) main
cmake                  | (t) v3.10.0 (DH)                 | (b) develop
ecbuild                | (t) geos/v1.2.0 (DH)             | (t) geos/v1.2.0 (DH)
NCEP_Shared            | (t) v1.2.0 (DH)                  | (t) v1.2.0 (DH)
GMAO_Shared            | (t) v1.5.1 (DH)                  | (t) v1.5.1 (DH)
MAPL                   | (t) v2.17.2 (DH)                 | (b) develop
FMS                    | (t) geos/2019.01.02+noaff.7 (DH) | (t) geos/2019.01.02+noaff.7 (DH)
GEOSgcm_GridComp       | (t) v1.15.0 (DH)                 | (t) v1.15.0 (DH)
FVdycoreCubed_GridComp | (t) v1.6.0 (DH)                  | (t) v1.6.0 (DH)
fvdycore               | (t) geos/v1.3.0 (DH)             | (t) geos/v1.3.0 (DH)
GEOSchem_GridComp      | (t) v1.8.1 (DH)                  | (t) v1.8.1 (DH)
HEMCO                  | (t) geos/v2.2.2 (DH)             | (t) geos/v2.2.2 (DH)
geos-chem              | (t) geos/v13.0.0-rc1 (DH)        | (t) geos/v13.0.0-rc1 (DH)
GOCART                 | (t) v2.0.4 (DH)                  | (t) v2.0.4 (DH)
mom                    | (t) geos/5.1.0+1.2.0 (DH)        | (t) geos/5.1.0+1.2.0 (DH)
mom6                   | (t) geos/v2.0.2 (DH)             | (t) geos/v2.0.2 (DH)
RRTMGP                 | (t) geos/v1.5+1.0.0 (DH)         | (t) geos/v1.5+1.0.0 (DH)
GEOSgcm_App            | (t) v1.7.0 (DH)                  | (t) v1.7.0 (DH)
UMD_Etc                | (t) v1.0.4 (DH)                  | (t) v1.0.4 (DH)
CPLFCST_Etc            | (t) v1.0.1 (DH)                  | (t) v1.0.1 (DH)

If no repos differ, you see:

❯ mepo compare
No repositories have changed
❯ mepo compare --all
No repositories have changed

@mathomp4 mathomp4 added the enhancement New feature or request label Mar 24, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner March 24, 2022 15:13
@mathomp4 mathomp4 self-assigned this Mar 24, 2022
@pchakraborty
Copy link
Collaborator

Part of me even wonders if the brief behavior should be the default and we should do a --full or --all option that shows everything? Hmm.

I think it's a good idea to make brief the default behavior. When we run mepo compare, the idea is to see the differences.

@mathomp4 mathomp4 marked this pull request as draft March 24, 2022 18:42
@mathomp4
Copy link
Member Author

Part of me even wonders if the brief behavior should be the default and we should do a --full or --all option that shows everything? Hmm.

I think it's a good idea to make brief the default behavior. When we run mepo compare, the idea is to see the differences.

The creator appears! 😄

Any thoughts, @tclune ? My guess is no one has any scripts that depend on the compare output being in full, so I could fiddle around and make the brief behavior the default.

@tclune
Copy link
Contributor

tclune commented Mar 24, 2022

No strong opinions. I agree with @pchakraborty on general grounds. But I don't use the tool enough to have strong feelings.

@mathomp4
Copy link
Member Author

Okay. Give me a bit and I'll work on implementing it...

@mathomp4 mathomp4 changed the title Add brief option to compare Make compare brief by default, add --all options Mar 24, 2022
@mathomp4 mathomp4 marked this pull request as ready for review March 24, 2022 19:42
@mathomp4 mathomp4 changed the title Make compare brief by default, add --all options Make compare brief by default, add --all option Mar 24, 2022
@mathomp4
Copy link
Member Author

Change is implemented.

@mathomp4 mathomp4 merged commit e5a6674 into develop Mar 25, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/brief-compare branch March 25, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants