Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for unit testing and plotting #137

Merged
merged 6 commits into from
Apr 22, 2023
Merged

Documentation for unit testing and plotting #137

merged 6 commits into from
Apr 22, 2023

Conversation

PennyHow
Copy link
Member

In response to #135 and #136, these changes address the following:

These can be viewed on the readthedocs flavour of this repo branch here.

@PennyHow PennyHow added the documentation Improvements or additions to documentation label Apr 20, 2023
@PennyHow
Copy link
Member Author

@jroettenbacher, did you want to review this PR as it is related to your JOSS review?

@jroettenbacher
Copy link
Contributor

Sure, I can have a look!

Copy link
Contributor

@jroettenbacher jroettenbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like that you used both the pandas and xarray plotting possibility and also referenced the packages for further plotting options. This is all one needs I think.

docs/install.rst Outdated Show resolved Hide resolved
docs/install.rst Outdated Show resolved Hide resolved
@PennyHow PennyHow merged commit 08cd0c8 into main Apr 22, 2023
@PennyHow PennyHow deleted the docs-plt-test branch April 22, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants