-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/Automatically update AWS_stations_metadata.csv and AWS_sites_metadata.csv from L3 files #277
Open
BaptisteVandecrux
wants to merge
9
commits into
feature/surface-heights-and-thermistor-depths
Choose a base branch
from
feature/automatically-update-metadata-CSV-files
base: feature/surface-heights-and-thermistor-depths
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR to change file path inference is now here: #279 |
PennyHow
requested changes
Jul 9, 2024
'lat_last_known': lat_last_known, | ||
'lon_last_known': lon_last_known, | ||
'alt_last_known': alt_last_known | ||
}, name=s_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could split this step into its own function (from line 43-89) for constructing metadata from a single csv file... I think I will open a PR with all these changes to address this function split.
* paths specified
* paths specified
…ps://github.com/GEUS-Glaciology-and-Climate/pypromice into feature/automatically-update-metadata-CSV-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that, every time the level 3 data is processed, we read the output files and update the
AWS_stations_metadata,csv
andAWS_sites_metadata.csv
with the latest timestamps and coordinates.Since not every station is updated at each iteration, the script needs to first load the existing file and then only update the necessary rows.
Requires small edits of AWS-operational-processing:
https://github.com/GEUS-Glaciology-and-Climate/aws-operational-processing/pull/35