Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psalm use new baseline in action #350

Open
rinkp opened this issue Oct 7, 2023 · 1 comment
Open

Psalm use new baseline in action #350

rinkp opened this issue Oct 7, 2023 · 1 comment
Labels
For: CI/CD Continous integration/deployment (GitHub Actions)

Comments

@rinkp
Copy link
Member

rinkp commented Oct 7, 2023

What would you like?

We should use the new Psalm baseline when running a GitHub action.
Why? We continuously have to update the baseline and then PRs cannot be merged

PR reviewers can see that the baseline has changed and should manually deny PRs for which there is an unnecessary baseline change

Why is this needed?

No response

Other information

No response
@rinkp rinkp added the For: CI/CD Continous integration/deployment (GitHub Actions) label Oct 7, 2023
@rinkp rinkp mentioned this issue Oct 7, 2023
Merged
@tomudding
Copy link
Member

I actually think Psalm does not support the usage of two baselines like PHPStan does. So we should probably not try to generate a baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For: CI/CD Continous integration/deployment (GitHub Actions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomudding @rinkp