Add Reappointment subdecision for installations in bodies
#347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psalm issue is already in the baseline (we really should find a fix to make this work in the action). There are currently no checkers for this new functionality. |
tomudding
force-pushed
the
feature/reappointment-decision
branch
from
ed0bb13
to
a2c797e
Compare
|
rinkp
requested changes
Oct 7, 2023
This adds a new type of organ mutation, a reappointment. This mutation can be used to "prolong" the membership of a member in an organ. The subdecision refers to the original installation, just like a discharge. While a self-reference would have been nice (for consecutive reappointments), it introduces a lot of compexity due to the added recursion. As such, `Reappointment`s have a many-to-one relationship with `Installation`s. `Reappointment`s are processed before `Discharge`s and `Installation`s. In the Organ Mutations UI, only the `Lid` function can be directly reappointed. All other functions can be reappointed by checking the relevant functions in the model. This means that if a function is NOT checked it will not be reappointed, this means that a discharge for this particular function is created. Some of the JavaScript discharge functionality has been moved into a separate function to reduce code duplication. On top of that, the reappointments, discharges, and installations are now also sorted as such in the UI.
If there are two or more consecutive reappointments, then the modal is not cleared. This means that the functions from the previous member are still present. This can result in the accidental reappointment of these functions.
tomudding
force-pushed
the
feature/reappointment-decision
branch
from
a2c797e
to
0dc2bdb
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 12, 2023
Tom Udding: Merge pull request #347 from tomudding/feature/reappointment-decision Add `Reappointment` subdecision for installations in bodies Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new type of organ mutation, a reappointment. This mutation can be used to "prolong" the membership of a member in an organ. The subdecision refers to the original installation, just like a discharge.
While a self-reference would have been nice (for consecutive reappointments), it introduces a lot of compexity due to the added recursion. As such,
Reappointments have a many-to-one relationship withInstallations.Reappointments are processed beforeDischarges andInstallations.In the Organ Mutations UI, only the
Lidfunction can be directly reappointed. All other functions can be reappointed by checking the relevant functions in the model. This means that if a function is NOT checked it will not be reappointed, this means that a discharge for this particular function is created.Some of the JavaScript discharge functionality has been moved into a separate function to reduce code duplication. On top of that, the reappointments, discharges, and installations are now also sorted as such in the UI.
Before reappointment:
Reappointment modal:
Reappointment of membership and one additional function:
Resulting decision:
This closes GH-346 and closes ABC-2309-556 (pending IR changes).