Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country page: visually align and balance the metrics #228

Closed
4 tasks done
thom4parisot opened this issue Oct 9, 2018 · 3 comments · Fixed by #265
Closed
4 tasks done

Country page: visually align and balance the metrics #228

thom4parisot opened this issue Oct 9, 2018 · 3 comments · Fixed by #265

Comments

@thom4parisot
Copy link

thom4parisot commented Oct 9, 2018

  • structure as a definition list (<dl> / <dt> / <dd>)
  • on mobile: one metric = one row
  • on tablet: a combination which fits well the device width (1 metric = 1 row, 2 metrics = 1 row)
  • align margins with title and the table

image

@newick newick added this to To do in Frontend Iteration #2 (Oct 8th to Oct 19th) via automation Oct 9, 2018
@newick newick moved this from To do to In progress in Frontend Iteration #2 (Oct 8th to Oct 19th) Oct 18, 2018
@newick newick moved this from In progress to Needs review in Frontend Iteration #2 (Oct 8th to Oct 19th) Oct 18, 2018
@pzwsk
Copy link
Collaborator

pzwsk commented Oct 23, 2018

First column (Country Name) appears to be much larger than others on my screen.

image

@thom4parisot
Copy link
Author

Hello @pzwsk, this issue is about the metrics of a given country (eg: the Slovenia country page) and no the Countries list.

When we made the table responsive in #233, we flagged this issue, without creating a new one, my bad. This is due to later results being United Kingdom of Great Britain and Northern Ireland. We shall limit its width or make sure the country names wrap automatically in the column.

Can you create a new issue with your expectation of columns sizes? It would be super helpful.

@pzwsk pzwsk closed this as completed Oct 30, 2018
Frontend Iteration #2 (Oct 8th to Oct 19th) automation moved this from Needs review to Done Oct 30, 2018
@pzwsk pzwsk reopened this Oct 30, 2018
Frontend Iteration #2 (Oct 8th to Oct 19th) automation moved this from Done to In progress Oct 30, 2018
@pzwsk
Copy link
Collaborator

pzwsk commented Oct 30, 2018

While reviewing this, I found an issue with width of footer on country page https://dev.riskopendata.org/dataset_list.html?idcountry=SI&idcategory=0

Frontend Iteration #2 (Oct 8th to Oct 19th) automation moved this from In progress to Done Nov 8, 2018
thom4parisot pushed a commit that referenced this issue Nov 8, 2018
#228 Country page: visually align and balance the metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants