Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Use code-tag or syntax highlighting JS library for stack traces in failure tab #78

Closed
lanzelot1989 opened this issue Sep 10, 2018 · 4 comments
Closed

[Feature] Use code-tag or syntax highlighting JS library for stack traces in failure tab #78

lanzelot1989 opened this issue Sep 10, 2018 · 4 comments
Assignees
@elv1s42
Labels
enhancement report-improvements
Projects
Ghpr Common
Milestone
v0.9.3

Comments

@lanzelot1989
Copy link

lanzelot1989 commented Sep 10, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.
It is not easy to read stack traces in the current format.
image

Describe the solution you'd like
A "<code>" tag surrounding it or a special JS library like highlight.js or prismjs could solve this.
image
@lanzelot1989 lanzelot1989 changed the title Use <code> tag or syntax highlighting JS library for stack traces in failure tab [Feature] Use <code> tag or syntax highlighting JS library for stack traces in failure tab Sep 10, 2018
@lanzelot1989 lanzelot1989 changed the title [Feature] Use <code> tag or syntax highlighting JS library for stack traces in failure tab [Feature] Use &lt;code&gt; tag or syntax highlighting JS library for stack traces in failure tab Sep 10, 2018
@lanzelot1989 lanzelot1989 changed the title [Feature] Use &lt;code&gt; tag or syntax highlighting JS library for stack traces in failure tab [Feature] Use code-tag or syntax highlighting JS library for stack traces in failure tab Sep 10, 2018
@elv1s42 elv1s42 self-assigned this Sep 10, 2018
@elv1s42 elv1s42 added this to ToDo (Prioritised) in Ghpr Common via automation Sep 10, 2018
@elv1s42 elv1s42 added this to the v0.9.3 milestone Sep 10, 2018
@elv1s42
Copy link
Member

elv1s42 commented Sep 10, 2018

Hi @lanzelot1989 !

Agreed to use <code> tag for now.

Thank you for the feature request!

@elv1s42
Copy link
Member

elv1s42 commented Sep 10, 2018

Tested <code>, looks like this:

image

@lanzelot1989 , if you ok with this implementation I'll include it in the v0.9.3

@elv1s42 elv1s42 moved this from ToDo (Prioritised) to InProgress (Dev/QA) in Ghpr Common Sep 10, 2018
elv1s42 added a commit that referenced this issue Sep 10, 2018
@elv1s42
<code> tag to display stack trace
c3c4214 
#78
@elv1s42 elv1s42 moved this from InProgress (Dev/QA) to Done (Aw. Release) in Ghpr Common Sep 10, 2018
@lanzelot1989
Copy link
Author

looks good to me, thank you for the quick fix - keep up the good work!

@elv1s42 elv1s42 moved this from Done (Aw. Release) to Released (NuGet package) in Ghpr Common Sep 18, 2018
@elv1s42 elv1s42 moved this from Released (NuGet package) to Archive in Ghpr Common Sep 18, 2018
@elv1s42
Copy link
Member

elv1s42 commented Sep 20, 2018

Released in v0.9.3

@elv1s42 elv1s42 closed this as completed Sep 20, 2018
Ghpr Common automation moved this from Archive to Released (NuGet package) Sep 20, 2018
@elv1s42 elv1s42 moved this from Released (NuGet package) to Archive in Ghpr Common Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elv1s42 elv1s42

Labels
enhancement report-improvements
Projects
Ghpr Common
  
Archive
Milestone
v0.9.3
Development

No branches or pull requests
2 participants
@lanzelot1989 @elv1s42