Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Server Error when using changeset:… filter in non-contribution views #289

Closed
joker234 opened this issue Jan 4, 2023 · 2 comments · Fixed by #294
Closed

Internal Server Error when using changeset:… filter in non-contribution views #289

joker234 opened this issue Jan 4, 2023 · 2 comments · Fixed by #294
Assignees
Labels
bug Something isn't working

Comments

@joker234
Copy link
Member

joker234 commented Jan 4, 2023

Bug Description

When using non-contribution views (i.e. /elements/count) you get an Internal Server Error without a proper error message when a changeset filter is set (i.e. changeset:123).

General Information

Please include the following general information about the issue and list any additional steps needed to reproduce the bug.

Expected Behaviour

Throwing a proper error message

Further Information

Error Messages, Logs, Screenshots

{
  "timestamp": "2023-01-04T12:55:58.576+00:00",
  "status": 500,
  "error": "Internal Server Error",
  "path": "/elements/count"
}
@joker234 joker234 added the bug Something isn't working label Jan 4, 2023
@joker234 joker234 added this to To do in ohsome API general via automation Jan 4, 2023
@tyrasd

This comment was marked as resolved.

@tyrasd
Copy link
Member

tyrasd commented Feb 22, 2023

ah ok, I see now that the error only occurs if the bbox+filter combination includes any "potentially" matching objects. Like in this query:

https://api.ohsome.org/v1/elements/count?bboxes=8.67%2C49.39%2C8.71%2C49.42&filter=type:way%20and%20changeset:55639048&format=json&time=2022-01-01

The cause for this is the exception thrown at: https://github.com/GIScience/oshdb/blob/master/oshdb-filter/src/main/java/org/heigit/ohsome/oshdb/filter/ChangesetIdFilterEquals.java#L34

@tyrasd tyrasd self-assigned this Feb 22, 2023
tyrasd added a commit that referenced this issue Mar 9, 2023
* fix error message when changeset filter is used in snapshot query

closes #289

* add test
ohsome API general automation moved this from To do to Done Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants