Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all tests with using the filter parameter #98

Closed
FabiKo117 opened this issue Jan 20, 2021 · 1 comment · Fixed by #100
Closed

Update all tests with using the filter parameter #98

FabiKo117 opened this issue Jan 20, 2021 · 1 comment · Fixed by #100
Assignees
@FabiKo117
Labels
code quality Topics around code quality, e.g. refactoring, better naming of methods/classes
Milestone
1.4

Comments

@FabiKo117
Copy link
Contributor

Currently, there are still a lot of tests that are using the deprecated types/keys/values parameters. As the new developments don't consider these parameters anymore, but only build on the filter parameter, it is necessary to update all tests inside the ohsome API with the filter parameter to avoid running into bugs like fixed in this PR.
@FabiKo117 FabiKo117 added the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Jan 20, 2021
@FabiKo117 FabiKo117 added this to the 1.4 milestone Jan 20, 2021
@FabiKo117 FabiKo117 self-assigned this Jan 20, 2021
@FabiKo117
Copy link
Contributor Author

We still have some specific resources though, e.g. /groupBy/tag where the usage of parameters like groupByKey or groupByValues is still required. I guess we can leave those for now as is, as we would have to think before if we can also somehow represent them through the filter parameter, or keep them as they are.

@FabiKo117 FabiKo117 mentioned this issue Jan 20, 2021
Merged
5 tasks
FabiKo117 added a commit that referenced this issue Feb 5, 2021
@FabiKo117
updating tests to use filter parameter (#100)
92a1d6e 
instead of deprecated types, keys, values parameters
resolves #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabiKo117 FabiKo117

Labels
code quality Topics around code quality, e.g. refactoring, better naming of methods/classes
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

updating tests to use filter parameter GIScience/ohsome-api
1 participant
@FabiKo117