Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check repeated parameters #12

Merged
merged 4 commits into from
Jul 8, 2020
Merged

check repeated parameters #12

merged 4 commits into from
Jul 8, 2020

Conversation

bonaparten
Copy link
Contributor

No description provided.

@bonaparten bonaparten changed the title WIP: check repeated parameters WIP: check repeated parameters #7 Jul 6, 2020
@bonaparten bonaparten linked an issue Jul 6, 2020 that may be closed by this pull request
@bonaparten bonaparten changed the title WIP: check repeated parameters #7 WIP: check repeated parameters Jul 6, 2020
@bonaparten
Copy link
Contributor Author

I suppose, we only want to return a message 40x and let the user modify/remove the repeated parameter. Therefore, I made a simple implementation that splits the query string and checks if parameters are repeated. Let me know if this is a good solution for the issue.

@bonaparten bonaparten changed the title WIP: check repeated parameters check repeated parameters Jul 8, 2020
@bonaparten bonaparten requested a review from FabiKo117 July 8, 2020 12:23
@bonaparten bonaparten self-assigned this Jul 8, 2020
Copy link
Contributor

@FabiKo117 FabiKo117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@FabiKo117 FabiKo117 merged commit 2183bb7 into master Jul 8, 2020
@FabiKo117 FabiKo117 deleted the repeated-parameters branch July 8, 2020 13:20
@joker234 joker234 added this to Done in ohsome API general Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

discourage usage of repeated parameters for multiple values?
2 participants