mapping-saturation: change axis label of plot to aggregation type #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the problem here is that indicators with attached data don't have an endpoint. So we either have to use something else to label the axis in general or we use "Value" in this case and the endpoint for all others accordingly |
matthiasschaub
requested changes
Jul 3, 2023
Comment on lines
171
to
174
| if "endpoint" in self.topic: | ||
| fig.update_yaxes(title_text=self.topic.endpoint.split("/")[1].capitalize()) | ||
| else: | ||
| fig.update_yaxes(title_text="Value") |
There was a problem hiding this comment.
use topic.aggregation_type after #600 is merged
matthiasschaub
requested changes
Jul 11, 2023
workers/tests/integrationtests/indicators/test_mapping_saturation.py
Outdated
Show resolved
Hide resolved
matthiasschaub
previously approved these changes
Jul 11, 2023
matthiasschaub
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
y-axis of plot now has the aggregation type as label and not just "Value"
Corresponding issue
Closes #588
Checklist
main(e.g. throughgit rebase main)Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using
~...~) and remove their checkboxes.