split topic endpoint parameter to endpoint and aggregation_type #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasschaub
requested changes
Jun 26, 2023
| @@ -70,4 +70,75 @@ interactions: | |||
| - accept-encoding | |||
| http_version: HTTP/1.1 | |||
| status_code: 200 | |||
| - request: | |||
There was a problem hiding this comment.
Why did this cassette change?
|
Do not forget to update |
CHANGELOG.md
Outdated
| @@ -84,6 +84,7 @@ | |||
| - refactor: move base classes to related modules ([#524]) | |||
| - refactor: move topic-indicator-combinations to topic definition ([#528]) | |||
| - tests(vcr): don't record local requests and change cassettes directory structure ([#579]) | |||
| - split 'endpoint' parameter of topics to `endpoint` and `aggregation_type` ([#600]) | |||
There was a problem hiding this comment.
Add this to a new section # current main. A release happened since this PR.
This was referenced Jul 3, 2023
matthiasschaub
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Topic definitions now have one field for the used ohsome API endpoint and one field for the aggregation type.
New or changed dependencies
Checklist
main(e.g. throughgit rebase main)