Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add timeout for ohsome API metadata requests #541

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: add timeout for ohsome API metadata requests #541

merged 1 commit into from
Apr 11, 2023

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Apr 11, 2023 •
edited

Description

The metadata requests to the ohsome API got a timeout error, because the default httpx timeout was used.

Corresponding issue

Closes #537

New or changed dependencies

None

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@joker234 joker234 added the bug Something isn't working label Apr 11, 2023
@joker234 joker234 requested a review from Gigaszi April 11, 2023 11:19
@joker234 joker234 merged commit ea6c157 into main Apr 11, 2023
3 checks passed
@joker234 joker234 deleted the metadata-timeout branch April 11, 2023 11:33
joker234 added a commit that referenced this pull request Apr 11, 2023
@joker234
fix: add timeout for ohsome API metadata requests (#541)
a008729
@joker234 joker234 mentioned this pull request Apr 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gigaszi Gigaszi Gigaszi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle httpx.ConnectTimeout error in ohsome client module
2 participants
@joker234 @Gigaszi