Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework attribute completeness indicator #565

Closed
wants to merge 12 commits into from

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented May 4, 2023

Description

Attribute completeness of map features.

The ratio of features of a given topic to features of the same topic with additional
(expected) attributes.

Terminology:

  • topic: Category of map features. Translates to a ohsome filter.
  • attribute: Additional (expected) tag(s) describing a map feature. Translates to a ohsome filter.

Example: How many buildings (topic) have height information (attribute)?

Premise: Every map feature of a given topic should have certain additional attributes.

Corresponding issue

Closes #494

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md
  • Homogenize plotly figure to be similar to the others (E.g. Mapping Saturation)

@matthiasschaub
Copy link
Collaborator Author

matthiasschaub commented May 4, 2023

Should there be labels ("good", "medium", ...) in the chart. Either as legend or directly in the chart? Similar for values of the thresholds.

@matthiasschaub matthiasschaub changed the title Attribute completeness Rework attribute completeness indicator May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Ratio / Attribute Completeness Indicator - Meta-Issue
4 participants