Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheelchair parameters incorrect #264

Closed
rabidllama opened this issue Nov 8, 2018 · 0 comments · Fixed by #265
Closed

Wheelchair parameters incorrect #264

rabidllama opened this issue Nov 8, 2018 · 0 comments · Fixed by #265
Assignees
@TheGreatRefrigerator
Labels
bug
Projects
v0.3.6

Comments

@rabidllama
Copy link
Contributor

When passing wheelchair restrictions these should be inside the "restrictions" section of the "profile_params" as shown in the documentation. Currently they are being sent within the profile params object

"options": {"profile_params":{"surface_type":"any","maximum_sloped_curb":"0.31","maximum_incline":"31"}}

should be

"options": {"profile_params":{"restrictions":{"surface_type":"any","maximum_sloped_curb":"0.31","maximum_incline":"31"}}}

Also, in the above request the parameters were selected to be any surface, flexible incline, and flexible sloped kerb. In those cases, the parameters should just be omitted from the request
@rabidllama rabidllama added the bug label Nov 8, 2018
TheGreatRefrigerator added a commit that referenced this issue Nov 12, 2018
@TheGreatRefrigerator
Fix wheelchair params incorrect
4f89d6c 
wheelchair parameters are now added to options.profile_params.restrictions
instead of options.profile_params

Fix Wheelchair tooltip

refers to #264
@TheGreatRefrigerator TheGreatRefrigerator added this to Done in v0.3.6 Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheGreatRefrigerator TheGreatRefrigerator

Labels
bug
Projects
No open projects
v0.3.6
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v0.3.6 GIScience/openrouteservice-app
3 participants
@rabidllama @TimMcCauley @TheGreatRefrigerator