Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate openrouteservie-py to the year 2021 #60

Merged
merged 95 commits into from May 26, 2021

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented Feb 4, 2021

  • Adjust conda publish action to pick up the system wide package version.
  • integrate poetry
  • integrate tox
  • Add Readme instructions to use the new tools
  • Move to codecov. coveralls has a really buggy branch coverage detection. this makes coverage testing a pain. codecov seems to fit.

@MichaelsJP MichaelsJP self-assigned this Feb 4, 2021
@MichaelsJP MichaelsJP linked an issue Feb 4, 2021 that may be closed by this pull request
3 tasks
@MichaelsJP MichaelsJP changed the title migrate to poetry and tox Migrate openrouteservie-py to the year 2021 Feb 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@1d7b7e6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #60   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        12           
  Lines             ?       525           
  Branches          ?         0           
==========================================
  Hits              ?       525           
  Misses            ?         0           
  Partials          ?         0           
Flag Coverage Δ
unittests 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7b7e6...93021be. Read the comment docs.

Copy link
Collaborator

@TheGreatRefrigerator TheGreatRefrigerator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In general, i would suggest to cleanup feature branch commits by rebasing to keep the commits to review to a minimum and increase reviewability by a lot.

E.g. changes to pyproject.toml contain different mail addresses in the beginning that get fixed in further commits.
If it is an important change having information about mistakes being made that should be avoided in the future it can be kept to be accessible by git blame or PyCharm Annotations.

But especially typo fixes can be amended to a previous fitting commit to reduce the commit load for a PR.

In a similar manner, i often restructure my commits with changes to the same file into one if feasible.

Just as suggestion

@MichaelsJP MichaelsJP merged commit 0af44a1 into master May 26, 2021
@MichaelsJP MichaelsJP deleted the issue-59-integrate-best-practices branch May 26, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate best practices
4 participants