New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate openrouteservie-py to the year 2021 #60
Conversation
MichaelsJP
commented
Feb 4, 2021
•
edited
edited
- Adjust conda publish action to pick up the system wide package version.
- integrate poetry
- integrate tox
- Add Readme instructions to use the new tools
- Move to codecov. coveralls has a really buggy branch coverage detection. this makes coverage testing a pain. codecov seems to fit.
…tible to pep8 excluding some rules.
…ch is published during the action workflow.
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 12
Lines ? 525
Branches ? 0
==========================================
Hits ? 525
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
In general, i would suggest to cleanup feature branch commits by rebasing to keep the commits to review to a minimum and increase reviewability by a lot.
E.g. changes to pyproject.toml contain different mail addresses in the beginning that get fixed in further commits.
If it is an important change having information about mistakes being made that should be avoided in the future it can be kept to be accessible by git blame or PyCharm Annotations.
But especially typo fixes can be amended to a previous fitting commit to reduce the commit load for a PR.
In a similar manner, i often restructure my commits with changes to the same file into one if feasible.
Just as suggestion