Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all examples working again #61

Merged
merged 3 commits into from May 30, 2021
Merged

make all examples working again #61

merged 3 commits into from May 30, 2021

Conversation

koebi
Copy link
Collaborator

@koebi koebi commented Feb 25, 2021

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 599689017

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.978%

Totals Coverage Status
Change from base Build 531737277: 0.04%
Covered Lines: 515
Relevant Lines: 548

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #61 (e1401d7) into master (0af44a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          525       525           
=========================================
  Hits           525       525           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af44a1...e1401d7. Read the comment docs.

@MichaelsJP MichaelsJP self-requested a review May 26, 2021 10:55
@MichaelsJP MichaelsJP linked an issue May 26, 2021 that may be closed by this pull request
Key will be deprecated anyways, so there is no point in meddling with
git internals to rewrite history. Not commiting it to the main repo
should be enough - especially when squashing and merging.
@MichaelsJP MichaelsJP merged commit ed5e5cd into master May 30, 2021
@MichaelsJP MichaelsJP deleted the update-examples branch May 30, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

various issues in examples
4 participants