Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for 'maximum_speed' in directions #66

Merged
merged 2 commits into from
May 31, 2023
Merged

feat: Add support for 'maximum_speed' in directions #66

merged 2 commits into from
May 31, 2023

Conversation

kenspeckle1
Copy link
Contributor

@kenspeckle1 kenspeckle1 commented Jun 8, 2021 •
edited
Loading

Add an option for 'maximum_speed' for the directions() method. This fixes #62

koebi
koebi requested changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

thanks for the pull request :)
Could you add a test testing the new functionality? That'd be very much appreciated and shouldn't be too hard :)

Best regards,
Jakob

@kenspeckle1
Copy link
Contributor Author

Is it sufficient to add the parameter to test_helper.py as the test_directions test checks that the return value is equal to the parameters

@MichaelsJP MichaelsJP mentioned this pull request Mar 2, 2023
Open
@MichaelsJP MichaelsJP self-assigned this Mar 2, 2023
@MichaelsJP MichaelsJP changed the base branch from master to 62-directions-does-not-handle-maximum_speed-arguments May 31, 2023 14:52
@MichaelsJP MichaelsJP changed the title Add support for 'maximum_speed' in directions feat: Add support for 'maximum_speed' in directions May 31, 2023
@MichaelsJP MichaelsJP removed the request for review from koebi May 31, 2023 14:54
@MichaelsJP MichaelsJP merged commit 868403d into GIScience:62-directions-does-not-handle-maximum_speed-arguments May 31, 2023
1 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebi koebi koebi requested changes

Assignees

@MichaelsJP MichaelsJP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directions does not handle maximum_speed arguments
3 participants
@kenspeckle1 @koebi @MichaelsJP