Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Population fix #122

Merged
merged 11 commits into from Feb 23, 2018
Merged

Population fix #122

merged 11 commits into from Feb 23, 2018

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented Feb 22, 2018

Pull Request Checklist

  • 1. I have merged the latest version of the development branch into my feature branch and all conflicts have been resolved
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading
  • 3. I have documented my code using JDocs tags
  • 4. I have removed unecessary commented out code, imports and System.out.println statements

- [ ] 5. I have written JUnit tests for any new methods/classes and ensured that they pass
- [ ] 6. I have created API tests for any new functionality exposed to the API

  • 7. If changes/additions are made to the app.config file, I have added these to the app.config.sample file along with a short description of what it is for, and documented this in the Pull Request (below)
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue)

- [ ] 10. For new features involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors)

  • 11. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #106 .

Information about the changes

Required changes to app.config (if applicable)

Julian Psotta and others added 11 commits February 15, 2018 18:33
@rabidllama rabidllama added this to todo in ors v4.5 via automation Feb 23, 2018
@rabidllama rabidllama added this to the 4.5 milestone Feb 23, 2018
@rabidllama rabidllama moved this from todo to developed - waiting for merge in ors v4.5 Feb 23, 2018
@rabidllama rabidllama merged commit a833d00 into development Feb 23, 2018
ors v4.5 automation moved this from developed - waiting for merge to staged for release Feb 23, 2018
@MichaelsJP MichaelsJP deleted the population_fix branch February 27, 2018 09:00
@rabidllama rabidllama moved this from staged for release to released in ors v4.5 Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
ors v4.5
  
released
Development

Successfully merging this pull request may close these issues.

None yet

2 participants