Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundabout exit fix #108

Merged
merged 4 commits into from
Feb 8, 2018
Merged

Roundabout exit fix #108

merged 4 commits into from
Feb 8, 2018

Conversation

HendrikLeuschner
Copy link
Collaborator

Pull Request Checklist

  • 1. I have merged the latest version of the development branch into my feature branch and all conflicts have been resolved
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading
  • 3. I have documented my code using JDocs tags
  • 4. I have removed unecessary commented out code, imports and System.out.println statements
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass
  • 6. I have created API tests for any new functionality exposed to the API
  • 7. If changes/additions are made to the app.config file, I have added these to the app.config.sample file along with a short description of what it is for, and documented this in the Pull Request (below)
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue)
  • 10. For new features involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors)
  • 11. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes # .

Information about the changes

Required changes to app.config (if applicable)

Copy link
Contributor

@rabidllama rabidllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition to the changelog should be under the [Unreleased] heading

CHANGELOG.md Outdated
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- RPHAST performance optimisations (Issue #64)
- Updated duration calculations for urban areas (Issue #44)
- Increase hikari pool size for db connections (PR #52)
- Fix exception when roundabout exit is not correctly found (Issue #89)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added under [Unreleased] as it is not yet been merged into master (The unreleased items will be used during the release process to update the changelog for that particular release).

@rabidllama rabidllama merged commit 53774d8 into development Feb 8, 2018
@rabidllama rabidllama deleted the Roundabout_exit_fix branch February 9, 2018 09:33
MichaelsJP pushed a commit that referenced this pull request Feb 16, 2018
added new population data feature
resolves #108
MichaelsJP pushed a commit that referenced this pull request Feb 19, 2018
resolves #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants