Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate workflows for nightly and version docker images #1290

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

MichaelsJP
Copy link
Member

The current workflows do not cover scenarios where a release triggers the release workflow instead of a merge request with an included release tag.

@takb takb added this to To do in ors general Feb 22, 2023
…version

The current workflow cannot be correctly triggered if a release workflow run is triggered by a release. Separating it in two makes it easier to know on what condition a workflow is running.
@MichaelsJP MichaelsJP self-assigned this Feb 22, 2023
@MichaelsJP MichaelsJP requested a review from takb February 22, 2023 21:46
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, should makes it clearer

@takb takb merged commit feb65e0 into master Feb 23, 2023
ors general automation moved this from To do to Awaiting release Feb 23, 2023
@takb takb deleted the fix-github-release-workflow branch February 23, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ors general
  
Awaiting release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants