Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tomcat config overwrite #1311

Merged

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented Mar 6, 2023

The user config file is now used when the container is restarted or recreated.

Fixes #1300

Information about the changes

  • Reason for change: The recent docker setup ignored custom config files.

The user config file is now used when the container is restarted or recreated.
Fixes #1300
@MichaelsJP MichaelsJP linked an issue Mar 6, 2023 that may be closed by this pull request
@MichaelsJP MichaelsJP requested a review from koebi March 6, 2023 22:52
@takb takb added this to To do in ors general Mar 6, 2023
@MichaelsJP MichaelsJP self-assigned this Mar 6, 2023
@MichaelsJP MichaelsJP moved this from To do to Review in ors general Mar 6, 2023
The new docker setup uses different paths from the old. This check makes sure the setup doesn't start with the old paths and shows a notification to users.
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@takb takb merged commit 5baf15d into master Mar 7, 2023
ors general automation moved this from Review to Awaiting release Mar 7, 2023
@takb takb deleted the 1300-docker-compose-ors-configjson-not-taken-into-account branch March 7, 2023 09:37
@takb takb moved this from Awaiting release to Last release in ors general Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ors general
  
Last release
Development

Successfully merging this pull request may close these issues.

Docker compose ors-config.json not taken into account
2 participants