Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix old docker documentation #1326

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix old docker documentation #1326

merged 3 commits into from
Mar 14, 2023

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented Mar 14, 2023 •
edited

The docker documentation is outdated since version 6.8.2. This catches up with it and also includes how-tos on the old docker run setup.

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.

Information about the changes

  • Reason for change: With version 6.8.2 the docker how-to was outdated.

@MichaelsJP
docs(readme): fix old docker documentation
f77f3ca 
The docker documentation is outdated since version 6.8.2. This catches up with it and also includes how-tos on the old docker run setup.
@MichaelsJP MichaelsJP linked an issue Mar 14, 2023 that may be closed by this pull request
Fix the docker setup documentation #1298
Closed
@takb takb added this to To do in ors general Mar 14, 2023
@takb takb moved this from To do to Review in ors general Mar 14, 2023
takb
takb approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takb takb merged commit c45193e into master Mar 14, 2023
ors general automation moved this from Review to Awaiting release Mar 14, 2023
@takb takb deleted the 1298-fix-the-docker-setup-documentation branch March 14, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takb takb takb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ors general
  
Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the docker setup documentation
2 participants
@MichaelsJP @takb