Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(GTFS): profile name in api docs CUSTOM_KEYS #1328

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

takb
Copy link
Contributor

@takb takb commented Mar 14, 2023

  • Reason for change:
    Old profile names were still used in the CUSTOM_KEYS references

@takb takb requested a review from koebi March 14, 2023 11:20
@takb takb added this to To do in ors general Mar 14, 2023
@takb
Copy link
Contributor Author

takb commented Mar 14, 2023

I don't think we need to use the full profile name for these four strings you mention, the language file key is something internal and the leg type value for the responses only produce unnecessary bloat.

For the locales, only US and DE are added for the public transit, not sure if there are other languages should also have the pt object.

But you are right about this, I'll add untranslated values to the other language files. Thx for the heads-up!

translations are available for German and Japanese, all other languages fall back to English.
@takb takb merged commit f1aa07e into master Mar 14, 2023
ors general automation moved this from To do to Awaiting release Mar 14, 2023
@takb takb deleted the doc/fix-routerequest-customkeys-gtfs branch March 14, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ors general
  
Awaiting release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants