Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out the build from source settings #1335

Merged
merged 1 commit into from
Mar 15, 2023
Merged

comment out the build from source settings #1335

merged 1 commit into from
Mar 15, 2023

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented Mar 15, 2023 •
edited

Users are now building from nightly automatically. This is not desired!

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.

Touches #1331

Information about the changes

  • Key functionality added: Right now, when users start the docker-compose stack, they will build from nightly source.

@MichaelsJP MichaelsJP linked an issue Mar 15, 2023 that may be closed by this pull request
docker default build form source #1334
Closed
@takb takb added this to To do in ors general Mar 15, 2023
@MichaelsJP MichaelsJP requested a review from takb March 15, 2023 14:52
@MichaelsJP MichaelsJP self-assigned this Mar 15, 2023
takb
takb approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelsJP
build(docker): comment out the build from source settings.
b06165b 
Users are now building from nightly automatically. This is not desired!
@MichaelsJP MichaelsJP force-pushed the 1334-docker-default-build-form-source branch from 26902dd to b06165b Compare March 15, 2023 15:08
@MichaelsJP MichaelsJP changed the title comment out the build from source settings. comment out the build from source settings Mar 15, 2023
@MichaelsJP MichaelsJP merged commit ef6d3a6 into master Mar 15, 2023
ors general automation moved this from To do to Awaiting release Mar 15, 2023
@MichaelsJP MichaelsJP deleted the 1334-docker-default-build-form-source branch March 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takb takb takb approved these changes

Assignees

@MichaelsJP MichaelsJP

Labels
None yet
Projects
ors general
  
Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker default build form source
2 participants
@MichaelsJP @takb