Move Integration Tests to openrouteservice Module

[koebi]

Tasks

• Move over all tests
• Get rid of duplicate classes in integrationtests package
• Strip down pom.xml (remove out-commented code, unncessary plug-in, unused lifecycle hooks)
• Rename profile "surefire" to something more meaningful
• Document new way of integration testing
• fix flakey testConditionalAccess and testConditionalSpeed
• fix GetStatusTest waiting for Kafka
• delete openrouteservice-api-tests
• Delete MyIntegrationTest
• investigate cleanup ors.run for failed builds in maven-antrun-plugin
• delete uncommented unittest config setup method

Pull Request Checklist

• 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
  have been resolved.
• 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
  [Unreleased] heading.
• 3. I have documented my code using JDocs tags.
• 4. I have removed unnecessary commented out code, imports and System.out.println statements.
• 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
• 6. I have created API tests for any new functionality exposed to the API.
• 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
  along with a short description of what it is for, and documented this in the Pull Request (below).
• 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
• 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
• 10. For new features or changes involving building of graphs, I have tested on a larger dataset
  (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
• 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
  importer etc.), I have generated longer distance routes for the affected profiles with different options
  (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
  points generated from the current live ORS.
  If there are differences then the reasoning for these MUST be documented in the pull request.
• 12. I have written in the Pull Request information about the changes made including their intended usage
  and why the change was needed.
• 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Closes #1349
Closes #1345

Information about the changes

• Key functionality added:
• Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

[MichaelsJP]

@jlink @koebi One thing that just came up. Would it be possible to disable the debug logging of the integration tests in a normal run, maybe through an ENV variable?

The output is just so cluttered and confusing, and usually not needed in a normal run.

When an action fails, there is the option of re-executing an action in a debug session, which sets ACTIONS_RUNNER_DEBUG to true. We could let the integration tests listen to that variable and turn debug on/off conditionally. What do you think?

[sfendrich]

LGTM! Just a few minor comments.

[jlink]

log config can be done in the ors.config.json right?

[MichaelsJP]

Looking good.