-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add war deployment check #1356
Add war deployment check #1356
Conversation
4994e34
to
5e37d92
Compare
Currently, the war deployment is not checked. This starts the container and waits for the health API to indicate the default graph is built and ready.
5e37d92
to
1c1e5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work - asking because the build step seems to be hanging.
I don't understand all the details of the new build step, what strikes me is that the test will only be run on CI. That's rather late feedback. If that's ok, depends on how often we expect a problem with the war deployment.
Yes. The action name has changed, and it's still looking for the old. Will change that before the merge. Else, all other PRs will have to wait for it.
I'm open to ideas on how to solve that deployment scenario locally, as isolated as it is in the workflow with the Dockerfile. In my opinion, it's ok to have that kind of feedback latest with a PR, so there is no danger of merging it into master. It also runs on a draft PR, so feedback is given quick if commits are uploaded regularly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with your approach and think about a way to extract that from GH actions later.
7a0ee3c
to
d83111d
Compare
Currently, the war deployment is not checked. This starts the container and waits for the health API to indicate the default graph is built and ready.
Pull Request Checklist
have been resolved.
and why the change was needed.
Closes #1355
Information about the changes