Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(github,action): Introduce multi arch matrix build #1407

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feature(github,action): Introduce multi arch matrix build #1407

merged 2 commits into from
Apr 20, 2023

Conversation

MichaelsJP
Copy link
Member

@MichaelsJP MichaelsJP commented Apr 19, 2023 •
edited
Loading

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes #1036
Supersedes and Closes #1402

Information about the changes

  • Key functionality added: Platform support for docker + arm64

@MichaelsJP MichaelsJP linked an issue Apr 19, 2023 that may be closed by this pull request
High graph building/response time on Apple Silicon Processors #1391
Closed
@takb takb added this to To do in ors general Apr 19, 2023
@MichaelsJP MichaelsJP force-pushed the feature/1391-high-graph-buildingresponse-time-on-apple-silicon-processors branch 4 times, most recently from 2bcb16f to 2a11a59 Compare April 19, 2023 15:05
@MichaelsJP MichaelsJP force-pushed the feature/1391-high-graph-buildingresponse-time-on-apple-silicon-processors branch from 2a11a59 to cd8e4bb Compare April 19, 2023 15:15
@MichaelsJP MichaelsJP mentioned this pull request Apr 19, 2023
Closed
13 tasks
@MichaelsJP MichaelsJP marked this pull request as ready for review April 19, 2023 15:25
takb
takb approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but github is having trouble updating the workflow...

@MichaelsJP
Copy link
Member Author

LGTM, but github is having trouble updating the workflow...

Quickly adapted the checks.

@MichaelsJP MichaelsJP merged commit c06bd60 into master Apr 20, 2023
ors general automation moved this from To do to Awaiting release Apr 20, 2023
@MichaelsJP MichaelsJP deleted the feature/1391-high-graph-buildingresponse-time-on-apple-silicon-processors branch April 20, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takb takb takb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ors general
  
Awaiting release
Milestone
No milestone
2 participants
@MichaelsJP @takb